-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(ui): publish button shows locale-specific text without localized fields #14690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PatrikKozak
merged 3 commits into
main
from
fix/publish-button-locale-text-without-localized-fields
Nov 20, 2025
Merged
fix(ui): publish button shows locale-specific text without localized fields #14690
PatrikKozak
merged 3 commits into
main
from
fix/publish-button-locale-text-without-localized-fields
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blish button text
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Contributor
|
The file is a little hard to read, I suggested that we rename a couple variables to improve.
|
JarrodMFlesch
approved these changes
Nov 20, 2025
JarrodMFlesch
added a commit
that referenced
this pull request
Nov 20, 2025
Fixes incorrect default label for publishing with localization. Regression from #14690
Contributor
|
🚀 This is included in version v3.65.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the publish button logic to check whether a collection/global has localized fields before displaying locale-specific button text ("Publish in [locale]").
The button now only shows locale-specific text when both conditions are met:
localization.defaultLocalePublishOptionis set to'active'Why?
PR #13459 fixed the submenu "Publish in [specific locale]" button to not appear on collections without localized fields, but missed updating the main button label logic.
This caused the main publish button to display "Publish in [locale]" even when a collection had no localized fields (when
defaultLocalePublishOption: 'active'was set).How?
publishAllcalculation to checkcanPublishSpecificLocale(which includes thehasLocalizedFieldscheck) instead of just checking if localization is enabled{localization ? defaultLabel : label}to{canPublishSpecificLocale ? defaultLabel : label}Fixes #14386