IncludeDelegatorVoteView as an ActionView with Visible and Opaque Variants
#4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK, the comments are a bit unclear in the proto message, but grouping the |
27 tasks
cratelyn
force-pushed
the
ejmg/update-DelegatorVoteView-proto-doc
branch
from
cbff8fa to
7e4e6b0
Compare
|
rebased on the latest main, but we'll do that again pending two other forthcoming pr's. (cc: @erwanor) |
|
We intend to release this as part of Testnet 74. It'll need one more rebase after #4368 lands, then should be good to go. |
…ariants in proto documentation.
conorsch
force-pushed
the
ejmg/update-DelegatorVoteView-proto-doc
branch
from
7e4e6b0 to
ba8b6a2
Compare
conorsch
approved these changes
May 9, 2024
|
thank you for doing this @ejmg! this looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Small change to
transaction.protothat movesDelegatorVoteViewto be included in the section ofActionViews that are explicitly documented as havingOpaqueandVisiblevariants. Beyond generated protobuf code fromscripts/protobuf-codegen, there are no other changes.Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: