-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.0
🎉
#80
Release v0.5.0
🎉
#80
Conversation
pephub overhaul
More changes
I agree. Maybe when we port to react 😎 |
There is nothing set up. It is trivial to embed ~10,000 PEPS (takes about a minute). I've developed pepembed to accomplish just this. However a github action should be setup to run the embedding/indexing on a set schedule or some sort of update queue needs to be implemented. I.e. a column in the database with a boolean flag indicating the PEP should be indexed and again, a github action cronjob runs to index only those PEPs. Either way. Does @khoroshevskyi want to implement such a system? |
I emulated this after the GitHub API architecture. And here is another example. Dockerhub does something similar. Spotify does something similar with album tracks. They all follow this
Same as above, I just emulated the GitHub API setup.
Maybe. I'd like to discuss in the context of comments I made above re: other endpoints.
These are remnants of the |
@nsheff @khoroshevskyi Okay - I've addressed many things with some small tweaks. Things that linger that I feel warrant a discussion:
Notes
|
|
Im having issues connecting to qdrant inside docker, so I'm waiting for their devs to help me out. but I will merge this soon. |
Are @aliparslan 's changes in? |
So far just his changes to |
New release of pephub 🎉
This will be a complete overhaul of the pephub user interface, as well as a redesign of the API. The pephub server exposes many pages for viewing, navigating, and managing PEPs stored inside. These are supported by the new API which is located at
/api/v1/
. For a detail discussion of changes see: #73Added
Changed
/api/v1
Removed
There is so much here to review (61 changed files), it would be quite difficult to review everything. If people feel so inclined, they can review all of the files, otherwise, I thought the following code review designations seemed appropriate:
If both could pull the code and just test it and mess around to break it, that would also be helpful 😄