Webistrano not deploying .htaccess files

[tomfotherby]

This is a example of the rsync command that webistrano generates and executes as part of deployment:

rsync -lrpt --exclude='.svn' /var/www/live/shared/cached-copy/* /var/www/live/releases/20100812070050

Unfortunately, the above command doesn't copy over the .htaccess file from the cached-copy directory.

To fix the issue the rsync needs to remove the trailing star in the source path (or end with "/." instead of "/*").

For reference: OS: RHEL 5.5, rsync --version is "rsync version 2.6.8 protocol version 29"

[roidrage]

The code executing that command is not directly part of Webistrano. It simply utilizes Capistrano for running the actual deployment, where the issue should be raised instead. When it's fixed in Capistrano, we can apply the fix to the version bundled with Webistrano.

[tomfotherby]

Thanks. Opps just found that this issue was already raised on the capistrano website: https://capistrano.lighthouseapp.com/projects/8716/tickets/140-rsync-globbing-causes-hidden-files-to-be-skipped

The Capistrano guys seem to think this is a feature not a bug.

[markjaquith]

I opened a Capistrano pull request for this. Hopefully it will be accepted.

[tomfotherby]

Thanks for trying Mark but I doubt Capistrano will accept it because it will expose some people's source trees if they have .git or .svn files. Discussed previously in https://capistrano.lighthouseapp.com/projects/8716/tickets/140-rsync-globbing-causes-hidden-files-to-be-skipped.

[markjaquith]

I don't think that's a valid argument. Because note that rsync is only used if you have defined some excludes. If they haven't defined excludes, it just uses cp, so presumably they're already having those hidden directories copied if they're not explicitly excluding them. But we'll see.