[Mapbox] Adding country code to properties when available #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
simon04
requested changes
Apr 3, 2020
src/geocoders/mapbox.js
Outdated
| properties[id] = loc.context[j].text; | ||
|
|
||
| // Get country code when available | ||
| if (loc.context[j].short_code != 'undefined') { |
There was a problem hiding this comment.
Use one of the following variants (yours does not detect undefined correctly):
if (typeof loc.context[j].short_code !== 'undefined')if (loc.context[j].short_code !== undefined)if (loc.context[j].short_code)
I prefer variant 3.
There was a problem hiding this comment.
Got it ! I always struggle with those 'undefined' in JS..
Nick59
force-pushed
the
mapbox-country-code
branch
from
16f1db8 to
de5691a
Compare
simon04
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I'm working with this great tool and i have a very small suggestions to do to make it better :)
I'm working with Mapbox API and i need the country short code which is not parsed in property list.