Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug #6099 (igmpproxy does not recognize upstream interface) #182

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Fix Bug #6099 (igmpproxy does not recognize upstream interface) #182

merged 1 commit into from
Dec 23, 2016

Conversation

NewEraCracker
Copy link
Contributor

Here goes nothing 😃
https://redmine.pfsense.org/issues/6099

Hope this fills the gaps. I've tested it on 2.3.3 and recognized all intended interfaces.
Please backport it there, thanks.

PS: This repository is huge, cloning with small depth is still an herculean task, same with git commands that take about 60 seconds to do anything...

@NewEraCracker
Copy link
Contributor Author

NewEraCracker commented Sep 5, 2016 •
edited
Loading

Patch has been reworked with a new commit. I've also bumped PORTREVISION.

Old patch was tested on 2.4-amd64 and 2.3.3-amd64
New patch was tested on 2.4-amd64 and 2.3.3-i386

I trust there are no regressions with neither and only some good improvements!

@NewEraCracker
Copy link
Contributor Author

NewEraCracker commented Sep 5, 2016 •
edited
Loading

EDIT: I have realized this change in incorrect and has been undo-ed at: 009d60c

Reworking this to fix another bug regarding subnet handling on config.c

On ifvc.c subnets are handled as:

subnet = addr & mask;
allowednet->subnet_addr = subnet;

while on config.c:

tmpSubnet->subnet_addr = addr;

adding a patch to change that to:

tmpSubnet->subnet_addr = (addr & mask);

...and done.

I've now squashed all commits into one as I believe this makes the job easier to merge everything.

@NewEraCracker
Fix Bug #6099 (igmpproxy does not recognize upstream interface)
ca5f3cd 
+ Rewrite buildIfVc() to use getifaddrs() (ifvc.c)
  Based on original implementation in pfSense 2.2 and @ViToni work

Further tweaks to improve usability of igmpproxy

+ Do not add disabled VIFs (igmpproxy.c)
+ Fix handling of subnet addresses (config.c)
@rbgarga rbgarga requested a review from loos-br December 21, 2016 12:11
@netgate-git-updates netgate-git-updates merged commit ca5f3cd into pfsense:devel Dec 23, 2016
netgate-git-updates pushed a commit that referenced this pull request Dec 23, 2016
@loos-br
Merge pull request #182 from VPSrv/bug-6099
3cc4c55 
* 'bug-6099' of https://github.com/VPSrv/FreeBSD-ports:
  Fix Bug #6099 (igmpproxy does not recognize upstream interface)
@NewEraCracker NewEraCracker deleted the bug-6099 branch March 13, 2017 15:04
netgate-git-updates pushed a commit that referenced this pull request Apr 19, 2020
@ohauer
- update to 1.2.1
345ac71 
- set update instruction notes on pkg-message

ChangeLog v1.2.0:
    bumped minimum supported Python version to 2.4
    implemented support for property diffs (Tigris #383)
    allow user-configurable cvsgraph display (Tigris #336)
    allow rNNNN syntax for Subversion revision numbers (Tigris #441)
    display revision numbers in CVS tag/branch selector (Tigris #546)
    allow roots to have optional context (#58)
    use a more secure temporary file generator (#159)
    fix problems with make-database and special characters (#141, #182)
    fix bogus default ci_when value in cvsdb (#200)
    standalone query interface removed (#206)
    GUI support (--gui) removed from standalone.py

ChangeLog v1.2.1:
    security fix: escape subdir lastmod file name

PR:		245728
Submitted by:	Yasuhito FUTATSUKI
netgate-git-updates pushed a commit that referenced this pull request Jun 15, 2020
Update to 0.2.5
e9b3990 
Build now explicitly requires gmake

per https://github.com/yaml/libyaml/releases/tag/0.2.5
the following changes have been made

- #105
  Allow question marks in plain scalars in flow collections

- #186
  Emitter: Don't output trailing space for empty scalar nodes

- #185
  Emitter: Output space after an alias mapping key

- #187
  Add -h and --flow (on|off|keep) to run-*-test-suite

- #182
  Remove unnecessary include and malloc

- #177
  Add specific files back to .gitignore

- #181
  Output error position in run-parser-test-suite.c

- #191
  A couple patches to improve test suite support

- #179
  Flow indicators can not be part of local or shorthand tags

PR:	247043
Submitted by:	daniel.engberg.lists@pyret.net
netgate-git-updates pushed a commit that referenced this pull request Jun 24, 2022
@mfechner
www/rubygem-rack-timeout: update to 0.6.3
ce6f922 
Required for gitlab-ce 15.1
Changelog:
https://github.com/zombocom/rack-timeout/blob/v0.6.3/CHANGELOG.md

0.6.3

    Fix NoMethodError: undefined method 'logger' for Rails:Module when Rails is defined as a Module, but is not a full Rails app (#180)

0.6.2

    Migrate CI from Travis CI to GitHub Actions (#182)
    Rails 7+ support (#184)

0.6.1

    RACK_TIMEOUT_TERM_ON_TIMEOUT can be set to zero to disable (#161)
    Update the gemspec's homepage to the current repo URL(#183)

0.6.0

    Allow sending SIGTERM to workers on timeout (#157)
netgate-git-updates pushed a commit that referenced this pull request Mar 28, 2023
@mfechner
security/rubygem-doorkeeper-openid_connect: update to 1.8.5
8755d71 
v1.8.5 (2023-02-02)

    [#186] Simplify gem configuration reusing Doorkeeper configuration option DSL (thanks to @nbulaj).
    [#182] Drop support for Ruby 2.6 and Rails 5 (thanks to @sato11).
    [#188] Fix dookeeper-jwt compatibility (thanks to @zavan).

v1.8.4 (2023-02-01)

    [#177] Replace json-jwt with ruby-jwt to align with doorkeeper-jwt (thanks to @kristof-mattei).
    [#185] Don't call active_record_options for Doorkeeper >= 5.6.3 (thanks to @zavan).
    [#183] Stop render consent screen when user is not logged-in (thanks to @nov).

Changelog:
https://github.com/doorkeeper-gem/doorkeeper-openid_connect/blob/master/CHANGELOG.md

Fixes also a problem with www/gitlab-ce:
rake aborted!
NoMethodError: undefined method `active_record_options' for #<Doorkeeper::Config:0x000000081fb0f0c8 @Orm=:active_record, @default_generator_method=:hex, @authenticate_resource_owner=#<Proc:0x000000081fb0ed80 /usr/local/www/gitlab-ce/config/initializers/doorkeeper.rb:13>, @resource_owner_from_credentials=#<Proc:0x000000081fb0ec68 /usr/local/www/gitlab-ce/config/initializers/doorkeeper.rb:25>, @refresh_token_enabled=true, @enforce_configured_scopes=true, @force_ssl_in_redirect_uri=false, @forbid_redirect_uri=#<Proc:0x000000081fb0ea10 /usr/local/www/gitlab-ce/config/initializers/doorkeeper.rb:67>, @enable_application_owner=true, @default_scopes=#<Doorkeeper::OAuth::Scopes:0x000000081fb17e30 @scopes=["api"]>, @optional_scopes=#<Doorkeeper::OAuth::Scopes:0x000000081fb177f0 @scopes=["read_api", "read_user", "read_repository", "write_repository", "sudo", "openid", "profile", "email"]>, @access_token_methods=[:from_access_token_param, :from_bearer_authorization, :from_bearer_param], @token_secret_strategy=Gitlab::DoorkeeperSecretStoring::Token::Pbkdf2Sha512, @token_secret_fallback_strategy=Doorkeeper::SecretStoring::Plain, @application_secret_strategy=Gitlab::DoorkeeperSecretStoring::Secret::Pbkdf2Sha512, @application_secret_fallback_strategy=Doorkeeper::SecretStoring::Plain, @grant_flows=["authorization_code", "password", "client_credentials"], @skip_authorization=#<Proc:0x000000081fb1ce58 /usr/local/www/gitlab-ce/config/initializers/doorkeeper.rb:109>, @base_controller="::Gitlab::BaseDoorkeeperController", @skip_client_authentication_for_password_grant=true, @application_model=Doorkeeper::Application(id: integer, name: string, uid: string, secret: string, redirect_uri: text, scopes: string, created_at: datetime, updated_at: datetime, owner_id: integer, owner_type: string, trusted: boolean, confidential: boolean, expire_access_tokens: boolean), @access_grant_model=Doorkeeper::AccessGrant(id: integer, resource_owner_id: integer, application_id: integer, token: string, expires_in: integer, redirect_uri: text, created_at: datetime, revoked_at: datetime, scopes: string, code_challenge: text, code_challenge_method: text), @access_token_model=Doorkeeper::AccessToken(id: integer, resource_owner_id: integer, application_id: integer, token: string, refresh_token: string, expires_in: integer, revoked_at: datetime, created_at: datetime, scopes: string)>

          if Doorkeeper.configuration.active_record_options[:establish_connection]
                                     ^^^^^^^^^^^^^^^^^^^^^^
/usr/local/www/gitlab-ce/config/environment.rb:7:in `<top (required)>'
Tasks: TOP => db:migrate => db:load_config => environment
(See full trace by running task with --trace)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loos-br loos-br Awaiting requested review from loos-br

Assignees

@loos-br loos-br

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewEraCracker @loos-br @netgate-git-updates