pfSense-pkg-net-snmp: Fix services

[dbaio]

• Service name must not use hyphens to not get conflicted with pfSenseHelpers.js
• Fix a typo in snmptrapd executable name
• Bump PORTREVISION

[doktornotor]

Not exactly sure since when does hyphen conflict with a piece of JS but it'd seem whole lot better to me to fix that broken piece of JS.

[dbaio]

Maybe since this commit and this one.

It is used in Status / Services page:

<a href="#" id="restartservice-net_snmptrapd" ><i class="fa fa-repeat" title="Restart Service"></i></a>
<a href="#" id="stopservice-net_snmptrapd"><i class="fa fa-stop-circle-o" title="Stop Service"></i></a>
<a href="#" id="restartservice-zabbix_agentd_lts" ><i class="fa fa-repeat" title="Restart Service"></i></a>
<a href="#" id="stopservice-zabbix_agentd_lts"><i class="fa fa-stop-circle-o" title="Stop Service"></i></a>

Status/Services --> Ajax
Status/Services
service-utils.inc --> get_service_control_links

That code can be fixed, yes, but changing the service name is also valid to keep services working even in not updated machines.

[doktornotor]

This also breaks (at least)

• ftp-proxy
• Squid (c-icap)

and in general introducing regressions with similar totally undocumented, arbitrary restrictions suck goats nuts, to put it mildly.

Filed a bug about this: https://redmine.pfsense.org/issues/7445

[dbaio]

There is no harm in changing the service names for this package because it's a new package under testing.
But if you (and @jim-p) don't agree I can withdraw that commit and let just the typo part in the executable name.

And very nice that you opened that bug on redmine, thank you.

[jim-p]

It's better not to mix changes in PRs anyhow. The typo fix should be separate.

I'd also prefer to see that service name limitation fixed, if possible, rather than rename the service.

[dbaio]

ok @jim-p, done.

[doktornotor]

Should be fixed with pfsense/pfsense@21a8edd so this one shouldn't be needed any more.

[jim-p]

This one is now just the typo fix, so it's OK