Skip to content

Conversation

jumski
Copy link
Contributor

@jumski jumski commented Oct 6, 2025

Remove planning documents now that map infrastructure is complete

This PR removes all planning documents that were used during the map infrastructure development. The map feature is now complete and fully integrated into the codebase, making these planning documents obsolete.

Specifically:

  • Removed PLAN.md which tracked the map infrastructure implementation progress
  • Removed PLAN_partial_completion.md which outlined failure handling strategies
  • Removed PLAN_step_output.md which detailed performance optimization plans
  • Removed PLAN_race_condition_testing.md which described testing approaches
  • Consolidated all temporary migrations into a single clean migration

These documents served as implementation guides during development but are no longer needed now that the features have been fully implemented. The code itself now serves as the source of truth for how map steps, failure handling, and output aggregation work.

Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 8dc0d99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 7 packages
Name Type
@pgflow/dsl Minor
@pgflow/core Minor
pgflow Minor
@pgflow/client Minor
@pgflow/edge-worker Minor
@pgflow/example-flows Minor
@pgflow/website Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Oct 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jumski jumski changed the title fix: implement comprehensive failure handling and message archiving for map infrastructure fix: remove temp migrations and prepare stack to be merged Oct 6, 2025
@jumski jumski marked this pull request as ready for review October 6, 2025 06:36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Copy link

nx-cloud bot commented Oct 6, 2025

View your CI Pipeline Execution ↗ for commit 8dc0d99

Command Status Duration Result
nx affected -t build --configuration=production... ✅ Succeeded 26s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 6m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 16:04:32 UTC

@jumski jumski force-pushed the 10-06-chore-consolidate-migrations-and-finalize branch from 672447d to d9bdc7c Compare October 6, 2025 08:35
@jumski jumski force-pushed the 09-26-docs-add-map-array-docs branch from 90350c4 to a2f5600 Compare October 6, 2025 15:25
@jumski jumski force-pushed the 10-06-chore-consolidate-migrations-and-finalize branch from d9bdc7c to 8084414 Compare October 6, 2025 15:25
… improve failure handling

- Renamed existing changesets for clarity
- Implemented map step type infrastructure in SQL core
- Added .map() method to Flow DSL with compile-time validation and type safety
- Enhanced failure handling to archive all pending messages on run failure
- Fixed type contract violations to fail immediately without retries
- Updated documentation and created detailed changeset
- Removed obsolete plan files and consolidated migration strategy
- Improved robustness and observability for map steps and failure scenarios
@jumski jumski force-pushed the 10-06-chore-consolidate-migrations-and-finalize branch from 8084414 to 8dc0d99 Compare October 6, 2025 15:48
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-230.pgflow.pages.dev

📝 Details:

  • Branch: 10-06-chore-consolidate-migrations-and-finalize
  • Commit: 5aee929dd7d9b5bad0d83c48a24a762d1118143e
  • View Logs

_Last updated: _

Copy link
Contributor

github-actions bot commented Oct 6, 2025

🔍 Preview Deployment: Playground

Deployment failed!

Please check the workflow logs for details.

Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

  • Oct 7, 8:28 AM UTC: jumski added this pull request to the Graphite merge queue.
  • Oct 7, 8:29 AM UTC: CI is running for this pull request on a draft pull request (#232) due to your merge queue CI optimization settings.
  • Oct 7, 8:29 AM UTC: Merged by the Graphite merge queue via draft PR: #232.

graphite-app bot pushed a commit that referenced this pull request Oct 7, 2025
# Remove planning documents now that map infrastructure is complete

This PR removes all planning documents that were used during the map infrastructure development. The map feature is now complete and fully integrated into the codebase, making these planning documents obsolete.

Specifically:

- Removed [PLAN.md](http://PLAN.md) which tracked the map infrastructure implementation progress
- Removed PLAN_partial_completion.md which outlined failure handling strategies
- Removed PLAN_step_output.md which detailed performance optimization plans
- Removed PLAN_race_condition_testing.md which described testing approaches
- Consolidated all temporary migrations into a single clean migration

These documents served as implementation guides during development but are no longer needed now that the features have been fully implemented. The code itself now serves as the source of truth for how map steps, failure handling, and output aggregation work.
@graphite-app graphite-app bot closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant