fix: typecheck tests using strict tsc mode #231
Conversation
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| cat > "$TEMP_CONFIG" <<EOF | ||
| { | ||
| "extends": "./tsconfig.typecheck.json", | ||
| "include": ["$file"] | ||
| } | ||
| EOF |
There was a problem hiding this comment.
The JSON file path in the include array isn't properly escaped, which could cause syntax errors if the file path contains special characters like spaces or quotes. Consider using a JSON-aware tool like jq to generate valid JSON:
cat > "$TEMP_CONFIG" <<EOF
{
"extends": "./tsconfig.typecheck.json",
"include": [$(echo "$file" | jq -R .)]
}
EOFAlternatively, if jq isn't available, escape backslashes and quotes in the path:
ESCAPED_PATH=$(echo "$file" | sed 's/\\/\\\\/g' | sed 's/"/\\"/g')
cat > "$TEMP_CONFIG" <<EOF
{
"extends": "./tsconfig.typecheck.json",
"include": ["$ESCAPED_PATH"]
}
EOF| cat > "$TEMP_CONFIG" <<EOF | |
| { | |
| "extends": "./tsconfig.typecheck.json", | |
| "include": ["$file"] | |
| } | |
| EOF | |
| cat > "$TEMP_CONFIG" <<EOF | |
| { | |
| "extends": "./tsconfig.typecheck.json", | |
| "include": [$(echo "$file" | jq -R .)] | |
| } | |
| EOF |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t lint typecheck test --parallel -... |
❌ Failed | 6m 42s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-06 18:57:53 UTC
TL;DR
Improved TypeScript type checking with stricter validation and fixed map return type inference in the Flow DSL.
What changed?
typecheck-strict.shscript that performs two-pass type checking:@ts-expect-errordirectivestest:typesa dependency of the maintesttarget in multiple packagesAwaitedReturn<THandler>[]instead ofany[]map-return-type-inference.test-d.tsto verify proper type inferenceHow to test?
Run the type checking with the new script:
Run the type tests to verify the fixed map return type inference:
Verify that the main test command now includes type checking:
Why make this change?
The Flow DSL had a type inference bug where map step return types were incorrectly inferred as
any[]instead of preserving the specific return type structure. This made it difficult to catch type errors in subsequent steps that used the map output. The new strict type checking process also helps catch unused@ts-expect-errordirectives, which can hide real type errors when they're no longer needed.