[BUG]: call_user_func_array breaking change for php 8 in phalcon 5.4

[nadorator]

Description of the problem:
array_values($params) is missing in AbstractDispatcher.zep when using call_user_func_array.

This fix is already on 5.0.x branch but not 5.4.x

actual source code in 5.4.x:

public function callActionMethod(handler, string actionMethod, array! params = [])
    {
        return call_user_func_array(
            [handler, actionMethod],
            params
        );
    }

it should be:

public function callActionMethod(handler, string actionMethod, array! params = [])
    {
        return call_user_func_array(
            [handler, actionMethod],
            array_values(params)
        );
    }

Expected behavior
it should handle routing /admin/menu/:action/:params correctly and not report error on named parameters on compiled version of phalcon 5.4.

Error capture

trap: {"s":"35320","q":"\/admin\/menu\/get\/p\/0\/o\/asc"} {"type":1,"message":"Uncaught Error: Unknown named parameter $p in \/opt\/nenuphar\/src\/Clients\/index.php:39\nStack trace:\n#0 [internal function]: Phalcon\\Dispatcher\\AbstractDispatcher->callActionMethod()\n#1 [internal function]: Phalcon\\Dispatcher\\AbstractDispatcher->dispatch()\n#2 \/opt\/nenuphar\/src\/Clients\/index.php(39): Phalcon\\Mvc\\Application->handle()\n#3 {main}\n  thrown","file":"\/opt\/nenuphar\/src\/Clients\/index.php","line":39} [{"function":"Frog\\{closure}","args":[]}]

Details

• Phalcon version: Phalcon 5.4
• PHP Version: Php 8.2
• Operating System: Debian 12
• Installation type: Compiling from source
• Zephir version 1.7
• Server: Apache2

[sinbadxiii]

@nadorator Why don't you want to update to last version phalcon 5.9?

[nadorator]

@nadorator Why don't you want to update to last version phalcon 5.9?

Hello, because we use debian 11 server with only php 7.4. Admins are migrating to debian 12 php 8.2 but there is 22 servers to migrate, right now we have established a plan to migrate softly from php 7.4/phalcon 5.4 to php8.2/phalcon 5.4. Because phalcon 5.4 is compatible with both versions. Later we would migrate to php 8.4 and phalcon 5.9 but not yet. There is actual thousand of website that are running on those versions on our servers and we don't want to make any interruption of the service between migrations. Also it permits to still add new development in nearly real time on php 7.4/phalcon 5.4 version while preparing the update of the code in php 8.2. so the new version would have the new updates each day before activating the new servers in production.

Beside the urgence of this is becoming important because actually there is a automatic fix update on phalcon from debian repository and we are obliged to use a custom compiled version with the fixe for now. When the server will enter un production the automatic fix would be applied and then the custom version would be overwritten by the buggy version....