Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15133 event source null #15710

Merged
merged 3 commits into from
Oct 6, 2021
Merged

T15133 event source null #15710

merged 3 commits into from
Oct 6, 2021

Conversation

niden
Copy link
Member

@niden niden commented Oct 6, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Events\Event::construct() to allow source to be nullable

Thanks

@niden niden added breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low 5.0 The issues we want to solve in the 5.0 release labels Oct 6, 2021
@niden niden requested a review from Jeckerson October 6, 2021 14:44
@niden niden self-assigned this Oct 6, 2021
@niden niden linked an issue Oct 6, 2021 that may be closed by this pull request
[BUG]: Null cannot be set in the source parameter when firing an event. #15133
Closed
@niden niden merged commit 09521c1 into phalcon:5.0.x Oct 6, 2021
@niden niden deleted the T15133-event-source-null branch October 6, 2021 15:07
@niden niden mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Null cannot be set in the source parameter when firing an event.
2 participants
@niden @Jeckerson