Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15757 refactor escaper #15758

Merged
merged 6 commits into from
Nov 3, 2021
Merged

T15757 refactor escaper #15758

merged 6 commits into from
Nov 3, 2021

Conversation

niden
Copy link
Member

@niden niden commented Nov 3, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changes to Phalcon\Escaper

  • Moved Phalcon\Escaper to Phalcon\Html\Escaper
  • Moved Phalcon\Escaper\EscaperInterface to Phalcon\Html\Escaper\EscaperInterface
  • Moved Phalcon\Escaper\Exception to Phalcon\Html\Escaper\Exception
  • Deprecated methods (to be removed at a future version)
    • escapeCss() becomes css()
    • escapeJs(), becomes js()
    • escapeHtml() becomes html()
    • escapeHtmlAttr() becomes attributes()
    • escapeUrl() becomes url()
    • setHtmlQuoteType() becomes setFlags()

Thanks

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Nov 3, 2021
@niden niden requested a review from Jeckerson November 3, 2021 01:24
@niden niden self-assigned this Nov 3, 2021
@niden niden added the breaks bc Functionality that breaks Backwards Compatibility label Nov 3, 2021
@niden niden linked an issue Nov 3, 2021 that may be closed by this pull request
[NFR]: Refactor Escaper #15757
Closed
@niden niden merged commit 18a5848 into phalcon:5.0.x Nov 3, 2021
@niden niden deleted the T15757-refactor-escaper branch November 3, 2021 11:22
@niden niden mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Refactor Escaper
2 participants
@niden @Jeckerson