Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15799 di #15825

Merged
merged 5 commits into from
Dec 11, 2021
Merged

T15799 di #15825

merged 5 commits into from
Dec 11, 2021

Conversation

niden
Copy link
Member

@niden niden commented Dec 11, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Moved Phalcon\Di to Phalcon\Di\Di

Thanks

@niden niden self-assigned this Dec 11, 2021
@niden niden requested a review from Jeckerson December 11, 2021 20:07
@niden niden added 5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request labels Dec 11, 2021
@niden niden linked an issue Dec 11, 2021 that may be closed by this pull request
[NFR]: Move Di in Di #15799
Closed
@niden niden merged commit f3611dd into phalcon:5.0.x Dec 11, 2021
@niden niden deleted the T15799-di branch December 11, 2021 20:37
@niden niden mentioned this pull request Dec 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Move Di in Di
2 participants
@niden @Jeckerson