Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15853 escaper volt #15854

Merged
merged 3 commits into from
Jan 6, 2022
Merged

T15853 escaper volt #15854

merged 3 commits into from
Jan 6, 2022

Conversation

niden
Copy link
Member

@niden niden commented Jan 5, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected Phalcon\Mvc\View\Engine\Volt::escape_attr filter to use the correct method on the escaper

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jan 5, 2022
@niden niden requested a review from Jeckerson January 5, 2022 21:29
@niden niden self-assigned this Jan 5, 2022
@niden niden merged commit 7ab8219 into phalcon:5.0.x Jan 6, 2022
@niden niden deleted the T15853-escaper-volt branch January 6, 2022 10:15
@niden niden mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson