-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.x #15970
Merged
Merged
5.0.x #15970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
requested changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the interface as well with the two new methods. Also we need the CHANGELOG to be updated.
Great work!!
niden
added
enhancement
Enhancement to the framework
5.0
The issues we want to solve in the 5.0 release
labels
May 24, 2022
@ustmaestro Just update the changelog and this is ready!! |
niden
approved these changes
May 30, 2022
Thank you @ustmaestro ! |
Thank @ustmaestro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5.0
The issues we want to solve in the 5.0 release
documentation
Documentation required
enhancement
Enhancement to the framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Added support to class constants annotations
Thanks