Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16115 jwt validate #16116

Merged
merged 6 commits into from
Sep 23, 2022
Merged

T16115 jwt validate #16116

merged 6 commits into from
Sep 23, 2022

Conversation

niden
Copy link
Member

@niden niden commented Sep 23, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Encryption\Security\JWT\Token\Token::validate() to correctly call validator methods

Thanks

@niden niden self-assigned this Sep 23, 2022
@niden niden added bug A bug report status: high High 5.0 The issues we want to solve in the 5.0 release labels Sep 23, 2022
@niden niden linked an issue Sep 23, 2022 that may be closed by this pull request
[BUG]: New method ->validate() from JWT\Token internally calls undefined method #16115
Closed
Jeckerson
Jeckerson previously approved these changes Sep 23, 2022
View reviewed changes
Jeckerson
Jeckerson previously approved these changes Sep 23, 2022
View reviewed changes
@niden niden changed the base branch from master to 5.0.x September 23, 2022 15:18
@niden niden merged commit 0a1641f into phalcon:5.0.x Sep 23, 2022
@niden niden deleted the T16115-jwt-validate branch September 23, 2022 16:33
@niden niden mentioned this pull request Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson left review comments

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: New method ->validate() from JWT\Token internally calls undefined method
2 participants
@niden @Jeckerson