Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16474 emulate prepares #16486

Merged
merged 7 commits into from
Dec 27, 2023
Merged

T16474 emulate prepares #16486

merged 7 commits into from
Dec 27, 2023

Conversation

niden
Copy link
Member

@niden niden commented Dec 27, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Db\Adapter\Pdo\Mysql to use PDO::ATTR_EMULATE_PREPARES and PDO::ATTR_STRINGIFY_FETCHES by default for performance reasons
Merged Phalcon\Db\AbstractDb with Phalcon\Db\Adapter\AbstractAdapter since the former was not used

Thanks

@niden niden added bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Dec 27, 2023
@niden niden requested a review from Jeckerson December 27, 2023 10:37
@niden niden self-assigned this Dec 27, 2023
@niden niden added the status: high High label Dec 27, 2023
@niden niden linked an issue Dec 27, 2023 that may be closed by this pull request
[BUG]: Significant performance issue in database queries after upgrading Phalcon v3.4 to v5.4 #16474
Closed
@niden niden merged commit 043a91a into phalcon:5.0.x Dec 27, 2023
34 checks passed
@niden niden mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Significant performance issue in database queries after upgrading Phalcon v3.4 to v5.4
2 participants
@niden @Jeckerson