Remove the default value for the test_suffix parameter #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a comma-separated list of values to the CLI argument --test-suffix has been deprecated in PHPUnit 11[1] and will no longer work in PHPUnit 12. Given that this action is sending its default value[2] anyways, there's no reason to explicitly provide this command line argument. Further, it's confusing that this command line argument is specified at all when nothing in my repo's configuration sets its value. [1]: sebastianbergmann/phpunit#5709 [2]: https://docs.phpunit.de/en/11.1/textui.html#selection
cookieguru
added a commit
to MergePHP/mergephp-website
that referenced
this pull request
Apr 13, 2024
* Remove calls to getMockForAbstractClass(), see [1] * Remove calls to PHPUnit method returnValueMap, see [2] * Work around issue with deprecated test_suffix CSV, see [3] * Do not explicitly add `-colors=always` since it is already added [4] [1]: sebastianbergmann/phpunit#5241 [2]: sebastianbergmann/phpunit#5423 [3]: php-actions/phpunit#64 [4]: https://github.com/php-actions/phpunit/blob/c27e49b5fd8cd59d032b7b4441d2e15f23cf6519/phpunit-action.bash#L154
cookieguru
added a commit
to MergePHP/mergephp-website
that referenced
this pull request
Apr 13, 2024
* Remove calls to getMockForAbstractClass(), see [1] * Remove calls to PHPUnit method returnValueMap, see [2] * Work around issue with deprecated test_suffix CSV, see [3] * Do not explicitly add `-colors=always` since it is already added [4] [1]: sebastianbergmann/phpunit#5241 [2]: sebastianbergmann/phpunit#5423 [3]: php-actions/phpunit#64 [4]: https://github.com/php-actions/phpunit/blob/c27e49b5fd8cd59d032b7b4441d2e15f23cf6519/phpunit-action.bash#L154
|
Thank you for this change. I notice the README is already up to date, so this would have been missed otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a comma-separated list of values to the CLI argument
--test-suffixhas been deprecated in PHPUnit 11 and will no longer work in PHPUnit 12. Given that this action is sending its default value anyways, there's no reason to explicitly provide this command line argument. Further, it's confusing that this command line argument is specified at all when nothing in my repo's configuration sets its value.