Recording pool fix #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also merge in logging in the recording pool
Current coverage is 23.57% (diff: 1.19%)@@ master #65 diff @@
==========================================
Files 19 21 +2
Lines 781 806 +25
Methods 87 89 +2
Messages 0 0
Branches 0 0
==========================================
- Hits 193 190 -3
- Misses 588 616 +28
Partials 0 0
|
|
@php-cache/featured-users What do you think? |
|
|
||
| // Tell the collector to add the new logger | ||
| $collectorDefinition->addMethodCall('addInstance', [$id, new Reference($id.'.recorder')]); | ||
| $collectorDefinition->addMethodCall('addInstance', [$id, new Reference($id)]); |
There was a problem hiding this comment.
Maybe update this comment
|
I'll add a test for the compiler pass and then I'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issue with the RecorderCachePool (used for Symfony data collection) implements TaggableCache. If the underlying cache implemnation (like apc cache) does not support tagging we have to decorate the implementation with TaggablePSR6PoolAdapter. But that causes trouble when using a ChainPool.
This PR introduce a Factory that choose a RecordingPool that implements the same interfaces as the CachePool.