Support static usage class Enforcer, optimize test case #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player626
reviewed
Apr 2, 2021
composer.json
Outdated
| "easyswoole/orm": "^1.4", | ||
| "easyswoole/easyswoole": "~3.3|~3.4" | ||
| "easyswoole/easyswoole": "~3.3|~3.4", |
|
@hlhill Compress your submission into a |
Player626
reviewed
Apr 2, 2021
tests/DatabaseAdapterTest.php
Outdated
| @@ -12,6 +12,23 @@ | |||
|
|
|||
| class DatabaseAdapterTest extends TestCase | |||
| { | |||
|
|
|||
| public function setUp() | |||
There was a problem hiding this comment.
Increase the return value void
Pull Request Test Coverage Report for Build 711466440
💛 - Coveralls |
Pull Request Test Coverage Report for Build 711466440Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@techoner review |
|
@techoner You see what else you need to pay attention to. I have read it once and can merge it. |
|
@techoner |
|
@hlhill Please modify commit messsge, refer to: https://github.com/semantic-release/semantic-release#commit-message-format |
|
@hlhill plz fix conflicts. |
Player626
reviewed
Apr 5, 2021
Comment on lines
+13
to
+14
| "ext-swoole": ">=4.4", | ||
| "casbin/casbin": "~3.0", |
Player626
reviewed
Apr 28, 2021
| @@ -34,9 +34,14 @@ | |||
| 'host' => '127.0.0.1', | |||
| 'port' => 3306, | |||
| 'user' => 'root', | |||
| 'password' => '', | |||
| 'database' => 'easyswoole_permission', | |||
| 'password' => 'root', | |||
phpunit.php
Outdated
Comment on lines
3
to
9
| defined("MYSQL_HOST") ?: define('MYSQL_HOST', '10.10.28.130'); | ||
| defined("MYSQL_PORT") ?: define('MYSQL_PORT', 3306); | ||
| defined("MYSQL_USER") ?: define('MYSQL_USER', 'root'); | ||
| defined("MYSQL_PASSWORD") ?: define('MYSQL_PASSWORD', 'root'); | ||
| defined("MYSQL_DATABASE") ?: define('MYSQL_DATABASE', 'test'); | ||
| defined("MYSQL_TIMEOUT") ?: define('MYSQL_TIMEOUT', 5); | ||
| defined("MYSQL_CHARSET") ?: define('MYSQL_CHARSET', 'utf8mb4'); |
|
@hlhill remove merge commits:
|
Player626
reviewed
Apr 29, 2021
composer.json
Outdated
| "easyswoole/orm": "^1.4", | ||
| "easyswoole/easyswoole": "~3.3|~3.4" | ||
| "easyswoole/easyswoole": "~3.3|~3.4", |
|
@hsluoyz @techoner direct squash and merge |
|
Done. |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.