Skip to content

Conversation

Player626
Copy link
Collaborator

No description provided.

@Player626
Copy link
Collaborator Author

Some internal optimizations have been made.

@Player626
Copy link
Collaborator Author

Do not publish release,Because I don't understand, is there only one operation class, Enforcer?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 663753483

  • -17 of 61 (72.13%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.1%) to 75.362%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Adapters/DatabaseAdapter.php 31 34 91.18%
src/Casbin.php 9 12 75.0%
src/Config.php 4 15 26.67%
Totals Coverage Status
Change from base Build 663173882: 9.1%
Covered Lines: 52
Relevant Lines: 69

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 18, 2021

Pull Request Test Coverage Report for Build 664172412

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 43 of 61 (70.49%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.8%) to 75.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Adapters/DatabaseAdapter.php 29 32 90.63%
src/Casbin.php 10 14 71.43%
src/Config.php 4 15 26.67%
Totals Coverage Status
Change from base Build 663173882: 8.8%
Covered Lines: 54
Relevant Lines: 72

💛 - Coveralls

@hsluoyz hsluoyz requested a review from leeqvip March 18, 2021 09:06
@hsluoyz
Copy link
Member

hsluoyz commented Mar 18, 2021

@techoner plz review.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 18, 2021

@basakest plz review.

@leeqvip
Copy link
Member

leeqvip commented Mar 25, 2021

@gaobinzhan Sorry for taking so long to respond, please modify commit messsge, refer to: https://github.com/semantic-release/semantic-release#commit-message-format , and merge multiple times into one commit

@hsluoyz
Copy link
Member

hsluoyz commented Mar 25, 2021

@gaobinzhan

@Player626
Copy link
Collaborator Author

@techoner Haha, it doesn't matter. Now it's compressed into a submission.

@leeqvip
Copy link
Member

leeqvip commented Mar 26, 2021

@gaobinzhan It would be better to modify the commit message to "refactor: A code change that neither fixes a bug nor adds a feature"

@Player626
Copy link
Collaborator Author

@techoner Like this

@leeqvip
Copy link
Member

leeqvip commented Mar 26, 2021

@techoner Like this

image
In this format, semantic-release will not trigger automatic release

@Player626
Copy link
Collaborator Author

How do I need to change it? You can write me a standard submission information directly.

@leeqvip
Copy link
Member

leeqvip commented Mar 26, 2021

How do I need to change it? You can write me a standard submission information directly.

Like this: "refactor: A code change that neither fixes a bug nor adds a feature".
For details, please refer to: Commit Message Format.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 26, 2021

@gaobinzhan I think you can use git append to modify the message of this commit:

image

to something like: "feature: add xxx feature" or "fix: fix bug about xxx"

@leeqvip leeqvip changed the title update: code adjustment refactor: A code change that neither fixes a bug nor adds a feature. Mar 26, 2021
@leeqvip leeqvip merged commit 2c70393 into php-casbin:master Mar 26, 2021
@leeqvip
Copy link
Member

leeqvip commented Mar 31, 2021

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants