Implement "Admin can see a daily report on the site" #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
bodom91
force-pushed
the
gh589_Admin_daily_report
branch
from
ed9a15d to
f9ed21d
Compare
Closed
php-coder
changed the title
|
Changes Unknown when pulling f9ed21d on bodom91:gh589_Admin_daily_report into ** on php-coder:master**. |
php-coder
requested changes
Aug 2, 2017
| t_catalog = Catalog | ||
| t_search = Search | ||
| t_view_suspicious_activities = view suspicious activities | ||
| t_daily_statistics = view daily statistics |
There was a problem hiding this comment.
s/t_daily_statistics/t_view_daily_statistics/
| } | ||
|
|
||
| @Override | ||
| public AdminDailyReport getDailyStatistics() { |
There was a problem hiding this comment.
s/getDailyStatistics/getDailyReport/
| } | ||
|
|
||
| @Override | ||
| public String getTextOfDailyStatisticsMail(AdminDailyReport report) { |
There was a problem hiding this comment.
s/getTextOfDailyStatisticsMail/prepareDailyStatistics/
| ); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Add @PreAuthorize(HasAuthority.VIEW_DAILY_STATS)
| mailService.sendDailyStatisticsToAdmin(getDailyStatistics()); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Add @PreAuthorize(HasAuthority.VIEW_DAILY_STATS)
bodom91
force-pushed
the
gh589_Admin_daily_report
branch
from
f9ed21d to
eb748c1
Compare
bodom91
force-pushed
the
gh589_Admin_daily_report
branch
from
eb748c1 to
6a92fcf
Compare
|
Changes Unknown when pulling 6a92fcf on bodom91:gh589_Admin_daily_report into ** on php-coder:master**. |
php-coder
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed to #589