Fix wrong call to mb_convert_encoding in resolve() #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The charset is extracted from the ContentType, and mb_convert_encoding is called, but the actual $content is never converted to UTF-8 ($content is not passed by reference in this method).
oscarotero
added a commit
that referenced
this pull request
Jan 3, 2014
Fix wrong call to mb_convert_encoding in resolve()
|
Many thanks, @damienalexandre !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The charset is extracted from the ContentType, and mb_convert_encoding is called, but the actual $content is never converted to UTF-8 ($content is not passed by reference in this method).