Handle facebook login page redirects in v3.x #416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so, here is the fix I needed to get v3.x working with Facebook.
The issue here is that some facebook urls that are redirecting to the login page and then returning a "invalid parameter" error from FB, Because you cant embed the login page. It a little strange and inconsistent, sometimes they redirect other times they don't.
Ones in this old format tend to work
https://www.facebook.com/permalink.php?story_fbid={post-id}
While the same one using the current format do not.
https://www.facebook.com/*/posts/{post-id}
To fix this I added a pattern for "www.facebook.com/login/*" to the Redirects.php class and get the intended url from the "next" parameter. This resolves the issue for me.
original issue here #415