Skip to content

Bandcamp links have the artist name as provider name #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2021
Merged

Bandcamp links have the artist name as provider name #430

merged 2 commits into from
Mar 6, 2021

Conversation

DieterHolvoet
Copy link
Contributor

Fixes #429.

@DieterHolvoet
Copy link
Contributor Author

I had to change the adapter selection logic in ExtractorFactory since every artist has its own subdomain on bandcamp.com. In general, I think it's safe to check for suffixes instead of whole hosts.

I already removed some newly redundant adapters in ExtractorFactory::$adapters. One thing to look out for is that in case there's an extractor for a specific subdomain, eg. gist.github.com, it should be put before the extractor of the main domain (github.com).

@oscarotero
Copy link
Collaborator

It looks good to me. Thanks!

@oscarotero oscarotero merged commit 556c75c into php-embed:master Mar 6, 2021
@DieterHolvoet DieterHolvoet deleted the bandcamp-provider-name branch March 21, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bandcamp links have the artist name as provider name
2 participants
@DieterHolvoet @oscarotero