Skip to content

Conversation

s1lver
Copy link

@s1lver s1lver commented Oct 25, 2021

I`m setting headers and properties

Снимок экрана 2021-10-25 в 17 13 04

If i use function $message->getHeaders() i get properties instead and if use $message->getProperties() i get headers!!!

This PR fixing it

Before fix

{"headers":{"delivery_mode":1,"user_id":"guest"}}

After fix

{"headers":{"traceparent":"00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01","z-traceparent":"dsjdhsjdhsjds"}}

@makasim
Copy link
Member

makasim commented Nov 23, 2021

This would be a huge BC break. There are a lot of projects which rely on current behavior, even though it's not correct.

@s1lver
Copy link
Author

s1lver commented Nov 30, 2021

This would be a huge BC break. There are a lot of projects which rely on current behavior, even though it's not correct.

Maybe add a description to UPGRADE.md?

@makasim
Copy link
Member

makasim commented Nov 30, 2021

That would require a version bump and a lot of work on my side. I'd prefer to avoid it.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@stale stale bot closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants