Skip to content

Fix types for Symfony 5.4 #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fix types for Symfony 5.4 #1225

merged 2 commits into from
Jan 27, 2022

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Dec 13, 2021 •
edited
Loading

image

@ruudk
Copy link
Contributor

ruudk commented Jan 4, 2022

@shyim Thanks for this. Could you please also fix the code style issue?

@shyim
Copy link
Contributor Author

shyim commented Jan 4, 2022

@ruudk done

@ruudk
Copy link
Contributor

ruudk commented Jan 4, 2022

@makasim Could you approve the workflow so that we can see if it passes?

@shyim
Copy link
Contributor Author

shyim commented Jan 7, 2022

@ruudk I guess the failing one fails also in master

@ruudk
Copy link
Contributor

ruudk commented Jan 25, 2022

@makasim What do you think, can this be merged?

@makasim makasim merged commit 28faa1a into php-enqueue:master Jan 27, 2022
@shyim
Copy link
Contributor Author

shyim commented Feb 1, 2022

Can we have this released, so we can get rid of that error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyim @ruudk @makasim