Add CacheAwareInterface, CacheAwareTrait and NullCache. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks good. Only thing I specially notice is inconsistency in the coding standard. |
|
I'll take care of that today. |
|
Ready for review now. |
|
I've opened a discussion on the mailing list about it: https://groups.google.com/forum/#!topic/php-fig/hZmfnwKqf1I Has this already been decided then ? |
|
I've added a PR against the new repo: php-fig/simplecache-util#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is related to this mailing-list post and originates from Psr/simple-cache #10 and Psr/simple-cache #11.
Should we create a new repo for this or include it in this repo, the question is open and to be discussed.