Skip to content

Updated to latest version of proposal #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2014

Conversation

weierophinney
Copy link
Contributor

Please merge only after php-fig/fig-standards#366 is merged; this patch syncs with those changes.

  • Refactors MessageInterface to only provide getters.
  • MessageInterface now defines getBody() to require that it return a
    StreamableInterface instance.
  • Removes Request and Response interfaces
  • Provides server-side interfaces:
    • IncomingRequestInterface, which provides accessors for HTTP
      properties and environment-specific items ($_SERVER, $_GET, $_POST,
      $_FILES, $_COOKIE, etc), and support for mutable "attributes".
    • OutgoingResponseInterface, which provides both accessors and
      mutators for all HTTP properties.
  • Provides client-side interfaces:
    • OutgoingRequestInterface, which provides accessors and mutators for
      all HTTP properties.
    • IncomingResponseInterface, which provides accessors for HTTP
      properties.
  • StreamableInterface removes attach().

- Refactors MessageInterface to only provide getters.
- MessageInterface now defines getBody() to require that it return a
  StreamableInterface instance.
- Removes Request and Response interfaces
- Provides server-side interfaces:
  - IncomingRequestInterface, which provides accessors for HTTP
    properties and environment-specific items ($_SERVER, $_GET, $_POST,
    $_FILES, $_COOKIE, etc), and support for mutable "attributes".
  - OutgoingResponseInterface, which provides both accessors and
    mutators for all HTTP properties.
- Provides client-side interfaces:
  - OutgoingRequestInterface, which provides accessors and mutators for
    all HTTP properties.
  - IncomingResponseInterface, which provides accessors for HTTP
    properties.
- StreamableInterface removes attach().
philsturgeon added a commit that referenced this pull request Nov 3, 2014
@philsturgeon philsturgeon merged commit 8d0a1c5 into php-fig:master Nov 3, 2014
@weierophinney
Copy link
Contributor Author

@philsturgeon Can you please tag this as 0.6.0? Thanks in advance!

@philsturgeon
Copy link
Contributor

I tagged it as 0.5.0 already.

@weierophinney
Copy link
Contributor Author

Ha! I just assumed 0.5.0 was the previous one -- thanks a ton, @philsturgeon ! I'll get phly/http updated to this shortly, and then send another lengthy missal to the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants