Initial draft #1
Conversation
| which does not support long type aliases. Therefore, it makes sense to enforce primary short type forms to be used to | ||
| have uniform syntax and prevent possible confusion. | ||
|
|
||
| ### 4.4. Public Survey |
There was a problem hiding this comment.
I would split this and other too-old-stuff coming from PSR-2 in a separate file... But maybe we can do it later, when we make changes to the PER.
There was a problem hiding this comment.
There's a lot of stuff from the meta doc we can probably just toss out at this point, and I'd honestly like to see the spec part split into multiple pages for ease of reading/editing. That's all post-1.0 though.
|
I think it's important that we capture the current state of PSR-12 in an initial commit before we start modifying it so that we can track on those changes more easily. We should be able to get that merged in before merging this one and have everything work as expected. |
|
@KorvinSzanto you mean pure PSR-12 text without any modifications? |
Co-authored-by: Alessandro Lai <alessandro.lai85@gmail.com>
| * **Entrance Vote:** https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/php-fig/P9atZLOcUBM/_jwkvlYKEAAJ | ||
| * **Approval Vote:** https://groups.google.com/forum/#!topic/php-fig/1uaeSMaDGbk | ||
| * **Entrance Vote:** | ||
| * **Approval Vote:** |
There was a problem hiding this comment.
This should be updated with the PER approval vote
|
|
||
| _**Note:** Order descending chronologically._ | ||
|
|
||
| * [Inspiration Mailing List Thread](https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/php-fig/wh9avopSR9k) | ||
| * [Initial Mailing List PSR Proposal Thread](https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/php-fig/MkFacLdfGso) | ||
| * |
There was a problem hiding this comment.
Might be good to include a link to PSR-12 here
| @@ -8,24 +8,24 @@ interpreted as described in [RFC 2119][]. | |||
|
|
|||
| ## Overview | |||
|
|
|||
| This specification extends, expands and replaces [PSR-2][], the coding style guide and | |||
| This specification is a live document that extends, expands and replaces [PSR-12][], the extended coding style guide and | |||
There was a problem hiding this comment.
In my opinion this document is not a living document. The latest commit is not the source of truth the CC approved tag is.
There was a problem hiding this comment.
Makes sense. Will fix that.
| * Robert Deutz | ||
| * | ||
| * | ||
| * |
There was a problem hiding this comment.
Probably want to get this list shored up now that we have an official WG
|
@KorvinSzanto I thought the idea was to tag PSR-12 original as 1.0.0 without any changes / fixes. |
|
That doesn't makes a whole lot of sense to me. I advocated for getting PSR-12 merged verbatim before this PR so that the git history would include all changes, I didn't mean to suggest that should also apply to the versioning. In my opinion a 1.0.0 should have proper metadata and not be labeled PSR-12. We should discuss more in discord. |
Do not merge before #2