This repository was archived by the owner on May 29, 2023. It is now read-only.
Curry all combinators #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an immutable `Curry` class allows creating a curry from any callable. Having this as a base class will allow additional functionality such as `Partial` to be added with minimal effort.
Having all combinators curried by default provides much greater flexibility for point-free programming.
|
Wow! This looks really great! As an update, my broadband has gone on holiday, estimated to be fixed within the next 12 hours, sigh... Once it's back up, I'll have a proper look at this. Regardless, really great work! |
i-am-tom
reviewed
Jun 13, 2017
| }, | ||
| "files": [ | ||
| "src/functions.php", | ||
| "src/curried.php" |
There was a problem hiding this comment.
Should both be exposed? The "uncurried" ones aren't all totally uncurried (thinking of compose, in particular), so it might be more helpful to hide the "original" functions and move them out of sight and mind.
There was a problem hiding this comment.
They have to be imported somehow, or PHP won't find them. However, both are contained in namespaces so they won't pollute the global namespace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of #3 and makes all combinators curried by default.
See 7608e66 for changes.