Script: allow running from git clone #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you git clone the repo and run `composer install` and then call the program like so: ```bash php path/to/gitclone/parallel-lint ``` For a non-composer based project, PHP-Parallel-Lint would fail with the following message: ``` You must set up the project dependencies, run the following commands: curl -s http://getcomposer.org/installer | php php composer.phar install ``` For a composer based project, i.e. which does have a `vendor/autoload.php` file, but that file may not contain references to the PHP-Parallel-Lint application, it would fail with the following hard error: ``` Fatal error: Uncaught Error: Class 'JakubOnderka\PhpParallelLint\Application' not found in path/to/gitclone/parallel-lint:66 ``` This small change allows the application to work correctly in that situation.
bloep
reviewed
Mar 22, 2020
| $autoloadLocations = [ | ||
| getcwd() . '/vendor/autoload.php', | ||
| getcwd() . '/../../autoload.php', | ||
| __DIR__ . '/vendor/autoload.php', |
There was a problem hiding this comment.
I have a similar case.
If you call the script from outside your project folder, the same error message appears.
e.g. my-project-in-subfolder/vendor/bin/parallel-lint
This would fix it:
Suggested change
| __DIR__ . '/vendor/autoload.php', | |
| __DIR__ . '/vendor/autoload.php', | |
| __DIR__ . '/../../autoload.php', |
There was a problem hiding this comment.
Yes, there are basically more issues with the autoloading. PR #2 was also a step in the right direction, but a more structural, stable solution is needed.
This was referenced Mar 23, 2020
Merged
|
Same fix applied in commit de81f0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you git clone the repo and run
composer installand then call the program like so:For a non-composer based project, PHP-Parallel-Lint would fail with the following message:
For a composer based project, i.e. which does have a
vendor/autoload.phpfile, but that file may not contain references to the PHP-Parallel-Lint application, it would fail with the following hard error:This small change allows the application to work correctly in that situation.
This is the same PR as previously pulled in PR JakubOnderka/PHP-Parallel-Lint#149