Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 3fde331

Browse files
committed
Merge pull request #1 from facebook/community
Sync with facebook/php-webdriver/
2 parents 0eb0a0a + 0b889d7 commit 3fde331

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
This project versioning adheres to [Semantic Versioning](http://semver.org/).
33

44
## Unreleased
5+
- Added ext-curl to composer.json
56
- Added CHANGELOG.md
67
- Added CONTRIBUTING.md with information and rules for contributors
78

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ $desired_capabilities->setCapability('acceptSslCerts', false);
6161
$driver = RemoteWebDriver::create($host, $desired_capabilities);
6262
```
6363

64-
* See https://code.google.com/p/selenium/wiki/DesiredCapabilities for more details.
64+
* See https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities for more details.
6565

6666
## Changelog
6767
For latest changes see [CHANGELOG.md](CHANGELOG.md) file.

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"source": "https://github.com/facebook/php-webdriver"
1212
},
1313
"require": {
14-
"php": ">=5.3.19"
14+
"php": ">=5.3.19",
15+
"ext-curl": "*"
1516
},
1617
"require-dev": {
1718
"phpunit/phpunit": "4.6.*"

lib/Remote/RemoteWebDriver.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,11 @@ public function execute($command_name, $params = array()) {
504504
$params
505505
);
506506

507-
$response = $this->executor->execute($command);
508-
return $response->getValue();
507+
if ($this->executor) {
508+
$response = $this->executor->execute($command);
509+
return $response->getValue();
510+
} else {
511+
return null;
512+
}
509513
}
510514
}

0 commit comments

Comments
 (0)