Merge pull request #639 from OndraM/feature/php-73

Travis builds on PHP 7.3

Author: OndraM

.travis.yml

@@ -3,10 +3,11 @@ sudo: false
 dist: trusty
 
 php:
-  - 5.6
-  - 7.0
-  - 7.1
-  - 7.2
+  - '5.6'
+  - '7.0'
+  - '7.1'
+  - '7.2'
+  - '7.3'
 
 env:
   global:
@@ -16,30 +17,37 @@ env:
 
 matrix:
   include:
+    # Codestyle check build
+    - php: '7.3'
+      env: CHECK_CODESTYLE=1
+      before_install:
+        - phpenv config-rm xdebug.ini
+      before_script: ~
+      script:
+        - composer require phpstan/phpstan-shim # Not part of require-dev, because it won't install on PHP 5.6
+        - composer analyze
+        - composer codestyle:check
+      after_script: ~
+      after_success: ~
+
+    # Build with lowest possible dependencies on lowest possible PHP
+    - php: '5.6'
+      env: DEPENDENCIES="--prefer-lowest"
+
     # Add build to run tests against Firefox inside Travis environment
-    - php: 7.2
+    - php: '7.3'
       env: BROWSER_NAME="firefox"
       addons:
         firefox: "45.8.0esr"
 
     # Add build to run tests against Chrome inside Travis environment
-    - php: 7.2
+    - php: '7.3'
       env: BROWSER_NAME="chrome" CHROME_HEADLESS="1"
       addons:
         chrome: stable
 
-    # Build with lowest possible dependencies
-    - php: 7.2
-      env: DEPENDENCIES="--prefer-lowest"
-
-    # Chrome on Travis build with lowest possible dependencies
-    - php: 7.2
-      env: BROWSER_NAME="chrome" CHROME_HEADLESS="1" DEPENDENCIES="--prefer-lowest"
-      addons:
-        chrome: stable
-
     # Saucelabs builds
-    - php: 7.2
+    - php: '7.3'
       env: SAUCELABS=1 BROWSER_NAME="firefox" VERSION="47.0" PLATFORM="Windows 10"
       before_script:
         - php -S 127.0.0.1:8000 -t tests/functional/web/ &>>./logs/php-server.log &
@@ -48,7 +56,7 @@ matrix:
         sauce_connect: true
         jwt:
           secure: HPq5xFhosa1eSGnaRdJzeyEuaE0mhRlG1gf3G7+dKS0VniF30husSyrxZhbGCCKBGxmIySoAQzd43BCwL69EkUEVKDN87Cpid1Ce9KrSfU3cnN8XIb+4QINyy7x1a47RUAfaaOEx53TrW0ShalvjD+ZwDE8LrgagSox6KQ+nQLE=
-    - php: 7.2
+    - php: '7.3'
       env: SAUCELABS=1 BROWSER_NAME="chrome" VERSION="74.0" PLATFORM="Windows 10"
       before_script:
         - php -S 127.0.0.1:8000 -t tests/functional/web/ &>>./logs/php-server.log &
@@ -57,7 +65,7 @@ matrix:
         sauce_connect: true
         jwt:
           secure: HPq5xFhosa1eSGnaRdJzeyEuaE0mhRlG1gf3G7+dKS0VniF30husSyrxZhbGCCKBGxmIySoAQzd43BCwL69EkUEVKDN87Cpid1Ce9KrSfU3cnN8XIb+4QINyy7x1a47RUAfaaOEx53TrW0ShalvjD+ZwDE8LrgagSox6KQ+nQLE=
-    - php: 7.2
+    - php: '7.3'
       env: SAUCELABS=1 BROWSER_NAME="MicrosoftEdge" VERSION="16.16299" PLATFORM="Windows 10"
       before_script:
         - php -S 127.0.0.1:8000 -t tests/functional/web/ &>>./logs/php-server.log &
@@ -67,19 +75,6 @@ matrix:
         jwt:
           secure: HPq5xFhosa1eSGnaRdJzeyEuaE0mhRlG1gf3G7+dKS0VniF30husSyrxZhbGCCKBGxmIySoAQzd43BCwL69EkUEVKDN87Cpid1Ce9KrSfU3cnN8XIb+4QINyy7x1a47RUAfaaOEx53TrW0ShalvjD+ZwDE8LrgagSox6KQ+nQLE=
 
-    # Codestyle check build
-    - php: 7.2
-      env: CHECK_CODESTYLE=1
-      before_install:
-        - phpenv config-rm xdebug.ini
-      before_script: ~
-      script:
-        - composer require phpstan/phpstan-shim # Not part of require-dev, because it won't install on PHP 5.6
-        - composer analyze
-        - composer codestyle:check
-      after_script: ~
-      after_success: ~
-
 cache:
   directories:
     - $HOME/.composer/cache

tests/functional/WebDriverCheckboxesTest.php

@@ -17,6 +17,10 @@
 
 use Facebook\WebDriver\Exception\NoSuchElementException;
 
+/**
+ * @covers \Facebook\WebDriver\WebDriverCheckboxes
+ * @covers \Facebook\WebDriver\AbstractWebDriverCheckboxOrRadio
+ */
 class WebDriverCheckboxesTest extends WebDriverTestCase
 {
     protected function setUp()

tests/functional/WebDriverRadiosTest.php

@@ -18,6 +18,10 @@
 use Facebook\WebDriver\Exception\NoSuchElementException;
 use Facebook\WebDriver\Exception\UnsupportedOperationException;
 
+/**
+ * @covers \Facebook\WebDriver\WebDriverRadios
+ * @covers \Facebook\WebDriver\AbstractWebDriverCheckboxOrRadio
+ */
 class WebDriverRadiosTest extends WebDriverTestCase
 {
     protected function setUp()

tests/functional/WebDriverSelectTest.php

@@ -20,6 +20,7 @@
 use Facebook\WebDriver\Exception\UnsupportedOperationException;
 
 /**
+ * @group exclude-saucelabs
  * @covers \Facebook\WebDriver\WebDriverSelect
  * @covers \Facebook\WebDriver\Exception\UnexpectedTagNameException
  */