Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise Getting Started example indentation #2713

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

timacdonald
Copy link
Contributor

There is inconsistent indentation within the "Getting started" section of the docs including the same example across different pages.

I feel that using 4 spaces is pretty established indentation in the PHP community and should be our standard within the docs.

This example:

Screen Shot 2023-08-27 at 7 33 48 am

is then repeated on different pages in the same section with different indentation.

Screen Shot 2023-08-27 at 7 35 00 am

Result

Screen Shot 2023-08-27 at 7 40 02 am

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is an improvement. Probably https://www.php.net/manual/en/tutorial.forms.php should also be updated, though.

@timacdonald
Copy link
Contributor Author

@TimWolla I've pushed changes for that example.

@TimWolla TimWolla merged commit 5ccb446 into php:master Aug 28, 2023
2 checks passed
@TimWolla
Copy link
Member

I've pushed a small fix to drop trailing whitespace (that wasn't your fault, but was exposed due to the change to the line) and then merged. Thank you!

@timacdonald
Copy link
Contributor Author

Appreciate it!

@timacdonald timacdonald deleted the tutorial-indent branch August 29, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants