Use semantic HTML tags for tutorial form
example
#2715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the form example by:
label
tags, rather than generic inaccessible<p>
tags.type
attribute from input tags.id
tag to theinput
so thatlabel
tags can reference them with theirfor
attibute.button
and provide custom text. Adding custom text between an HTML tag feels much more familiar than doing it within an attribute. This also matches how thelabel
works.label
/input
pairs.I can only assume that
<p>
tags were used for formatting. I don't think that a horizontal form is an issue and something we need to "format". I also don't think wrapping things in<p>
or<div>
is the way we should promote formatting in HTML, over CSSDocs before
Docs after
Rendered HTML before
Rendered HTML after
This PR contains the same commit to indent the form seen in #2713. This should allow both to merged / rejected independently without causing conflicts...that is if I know how git works lol 🤞