Address review comments

Girgias · Girgias · commit d901c38c52bb · 2025-10-25T17:22:50.000+01:00
diff --git a/Zend/zend_closures.c b/Zend/zend_closures.c
@@ -287,13 +287,13 @@ ZEND_METHOD(Closure, bindTo)
 	do_closure_bind(return_value, ZEND_THIS, newthis, scope_obj, scope_str);
 }
 
-static void zend_copy_parameters_array(uint32_t param_count, HashTable *argument_array) /* {{{ */
+static void zend_copy_parameters_array(const uint32_t param_count, HashTable *argument_array) /* {{{ */
 {
-	zval *param_ptr = ZEND_CALL_ARG(EG(current_execute_data), 1);;
+	zval *param_ptr = ZEND_CALL_ARG(EG(current_execute_data), 1);
 
 	ZEND_ASSERT(param_count <= ZEND_CALL_NUM_ARGS(EG(current_execute_data)));
 
-	while (param_count-->0) {
+	for (uint32_t i = 0; i < param_count; i++) {
 		Z_TRY_ADDREF_P(param_ptr);
 		zend_hash_next_index_insert_new(argument_array, param_ptr);
 		param_ptr++;

Original file line number	Diff line number	Diff line change
`@@ -287,13 +287,13 @@ ZEND_METHOD(Closure, bindTo)`
`287`	`287`	`do_closure_bind(return_value, ZEND_THIS, newthis, scope_obj, scope_str);`
`288`	`288`	`}`
`289`	`289`
`290`		`-static void zend_copy_parameters_array(uint32_t param_count, HashTable argument_array) / {{{ */`
	`290`	`+static void zend_copy_parameters_array(const uint32_t param_count, HashTable argument_array) / {{{ */`
`291`	`291`	`{`
`292`		`- zval *param_ptr = ZEND_CALL_ARG(EG(current_execute_data), 1);;`
	`292`	`+ zval *param_ptr = ZEND_CALL_ARG(EG(current_execute_data), 1);`
`293`	`293`
`294`	`294`	`ZEND_ASSERT(param_count <= ZEND_CALL_NUM_ARGS(EG(current_execute_data)));`
`295`	`295`
`296`		`- while (param_count-->0) {`
	`296`	`+ for (uint32_t i = 0; i < param_count; i++) {`
`297`	`297`	`Z_TRY_ADDREF_P(param_ptr);`
`298`	`298`	`zend_hash_next_index_insert_new(argument_array, param_ptr);`
`299`	`299`	`param_ptr++;`