Skip to content

Commit e929602

Browse files
authored
ext/soap: HTTP request micro optimisations. (#20516)
smart string is a bit overkill for the cookie id here.
1 parent 9c2c341 commit e929602

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

ext/soap/php_http.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,8 +1014,7 @@ int make_http_soap_request(
10141014
char *eqpos = strstr(cookie, "=");
10151015
char *sempos = strstr(cookie, ";");
10161016
if (eqpos != NULL && (sempos == NULL || sempos > eqpos)) {
1017-
smart_str name = {0};
1018-
int cookie_len;
1017+
size_t cookie_len;
10191018
zval zcookie;
10201019

10211020
if (sempos != NULL) {
@@ -1024,8 +1023,7 @@ int make_http_soap_request(
10241023
cookie_len = strlen(cookie)-(eqpos-cookie)-1;
10251024
}
10261025

1027-
smart_str_appendl(&name, cookie, eqpos - cookie);
1028-
smart_str_0(&name);
1026+
zend_string *name = zend_string_init(cookie, eqpos - cookie, false);
10291027

10301028
array_init(&zcookie);
10311029
add_index_stringl(&zcookie, 0, eqpos + 1, cookie_len);
@@ -1063,8 +1061,8 @@ int make_http_soap_request(
10631061
GC_ADDREF(uri->host);
10641062
}
10651063

1066-
zend_symtable_update(Z_ARRVAL_P(cookies), name.s, &zcookie);
1067-
smart_str_free(&name);
1064+
zend_symtable_update(Z_ARRVAL_P(cookies), name, &zcookie);
1065+
zend_string_release_ex(name, false);
10681066
}
10691067

10701068
cookie_itt = cookie_itt + cookie_len;

0 commit comments

Comments
 (0)