Uri\WhatWg\Url host validation when using withHost

[nyamsprod]

Description

The following code:

<?php
echo new Uri\WhatWg\Url('data:toto')->withHost('example.com')->toAsciiString();

Resulted in this output:

data://example.comtoto

But I expected this output instead:

an InvalidUrlException to be thrown

data URL are URLs with opaque path. URLs with opaque path always have a host which is null

tested using https://3v4l.org/J9IHN/rfc#vgit.master

PHP Version

Runtime: PHP 8.5.0-dev

Operating System

No response

[nyamsprod]

There's also the following error:

echo (new \Uri\WhatWg\Url('scheme://toto'))->withHost('[::1')->toAsciiString();

returns

scheme://toto

I was expecting an InvalidUrlException to be thrown since the IPv6 host is malformed.

see https://3v4l.org/nJCaD/rfc#vgit.master

[TimWolla]

There's also the following error:

Can you please file separate issues for different bugs? I won't handle that comment as part of this issue.

[TimWolla]

an InvalidUrlException to be thrown

This expectation is incorrect: It must be a noop, as per the WHATWG URL Standard. See also node.js:

> uri = new URL('data:toto');
URL {
  href: 'data:toto',
  origin: 'null',
  protocol: 'data:',
  username: '',
  password: '',
  host: '',
  hostname: '',
  port: '',
  pathname: 'toto',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}
> uri.host = 'example.com'
'example.com'
> uri
URL {
  href: 'data:toto',
  origin: 'null',
  protocol: 'data:',
  username: '',
  password: '',
  host: '',
  hostname: '',
  port: '',
  pathname: 'toto',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}
> uri.hostname = 'example.com'
'example.com'
> uri
URL {
  href: 'data:toto',
  origin: 'null',
  protocol: 'data:',
  username: '',
  password: '',
  host: '',
  hostname: '',
  port: '',
  pathname: 'toto',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

A fix is upstream at lexbor/lexbor#305.

[nyamsprod]

So the current behaviour is still wrong but no exception is to be expected it will "silently" not update the host correct ?

[TimWolla]

So the current behaviour is still wrong but no exception is to be expected it will "silently" not update the host correct ?

If the linked Lexbor fix is included, the setter will silently do nothing, correct.

[nyamsprod]

Will update my polyfill accordingly then.

[TimWolla]

I'll make sure to update the bundled version of Lexbor when the upstream fix is reviewed and merged, so you can test with the updated version then.