[RFC] Add SameSite parameter to cookie setting functions #10317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
cookies-samesite-param
branch
from
233c984
to
a9120e8
Compare
TimWolla
reviewed
Jan 15, 2023
|
|
||
| /* Verify that cookie is secure if using SameSite::None, see | ||
| * https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#samesitenone_requires_secure */ | ||
| if (!secure && zend_string_equals_literal(samesite, "None")) { |
There was a problem hiding this comment.
If this passes, this would be the second native enum. Leaving this link here for reference: #9679 (comment)
devnexen
reviewed
Jan 15, 2023
| @@ -85,7 +85,7 @@ function session_cache_limiter(?string $value = null): string|false {} | |||
|
|
|||
| function session_cache_expire(?int $value = null): int|false {} | |||
|
|
|||
| function session_set_cookie_params(array|int $lifetime_or_options, ?string $path = null, ?string $domain = null, ?bool $secure = null, ?bool $httponly = null): bool {} | |||
| function session_set_cookie_params(array|int $lifetime_or_options, ?string $path = null, ?string $domain = null, ?bool $secure = null, ?bool $httponly = null, SameSite $sameSite = SameSite::Lax): bool {} | |||
There was a problem hiding this comment.
just general feeling impression, the camel case feels out of place whereas is mostly lower case with underscore otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/same-site-parameter