include cleanup part 5 #10345
Closed
include cleanup part 5 #10345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Engine
Category: Optimizer
Extension: curl
Extension: filter
Extension: intl
Extension: json
Extension: libxml
Extension: mbstring
Extension: mysqlnd
Extension: oci8
Extension: opcache
Extension: openssl
Extension: pcre
Extension: pdo_pgsql
Extension: pdo_sqlite
Extension: pgsql
Extension: phar
Extension: random
Extension: session
Extension: shmop
Extension: soap
Extension: sockets
Extension: spl
Extension: sqlite3
Extension: standard
Extension: sysvmsg
Extension: zlib
SAPI: cgi
SAPI: cli
SAPI: fpm
labels
This eliminates the need to include zend_portability.h.
MaxKellermann
force-pushed
the
include_cleanup5
branch
from
27a5844 to
7b56e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "revert of revert" of my include cleanup PRs: #10216 #10220 #10279 #10300 ... plus a few more commits (including the DTrace fix #10334)
My previous work was reverted after @dstogov demanded it: #10220 (comment)
Meanwhile, I have posted a suggestion to update PHP's coding standard in favor of my cleanups:
#includedirectives #10338Until it is decided whether to accept my coding standard suggestion, I'll keep this PR up to date for you to review.