Add $before_needle argument to strrchr()
#11430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense. Could you just message to internals mailing list and if there are no objections for a week or two, we can merge this. |
bukka
reviewed
Jun 16, 2023
HypeMC
force-pushed
the
strrchr-before-needle
branch
from
bad9a75
to
0ab2d55
Compare
HypeMC
force-pushed
the
strrchr-before-needle
branch
from
0ab2d55
to
9679b4a
Compare
HypeMC
force-pushed
the
strrchr-before-needle
branch
from
9679b4a
to
21107dc
Compare
|
@bukka Hi, it's been a couple of weeks now since I've sent the message to internals mailing list, so I was wondering if this is ready to be merged now or is there something else I need to do? |
|
@HypeMC Ok I merged it as a small self contained feature. It was also sent to internals and the functionality is already available in different functions so think it's ok for 8.3 even though we are quite close to RC. |
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 24, 2023
This was referenced Aug 25, 2023
weirdan
added a commit
to weirdan/psalm
that referenced
this pull request
Aug 25, 2023
isfedorov
added a commit
to JetBrains/phpstorm-stubs
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar functions such as
strstr(),stristr()or its mb counterpartmb_strrchr()all have this parameter that allows returning part of the haystack before the occurrence of the needle. This function seems to be an exception.