fixed Bug #68621 #1159
Closed
fixed Bug #68621 #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can one of the admins verify this patch? |
| if (!(resolved_path = expand_filepath(filename->val, NULL))) { | ||
| RETURN_FALSE; | ||
| } | ||
| if (!strspn(filename->val,php_spn)) { |
There was a problem hiding this comment.
This seems to be only partial fix. What about any other streams? If we want to support streams here, it should support all streams, not only one specific stream.
|
Also, this patch seems to cause serious breakage in the tests, please look into it. |
Conflicts: ext/zip/php_zip.c ext/zip/tests/bug68621.phpt
|
The test case already revised, no problem now. |
|
This fix will return: php_error_docref(NULL, E_WARNING, "Cannot destroy the zip context"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZipArchive::open treats the filename not as defined per php manual on valid file wrappers. It appends the filename to the base url. Hence, creating/manipulating a zip file in memory space would be impossible.
https://bugs.php.net/bug.php?id=68621