Repository navigation
Add DOMNode::compareDocumentPosition() - #12146
Merged
Merged
Conversation
TimWolla
reviewed
Sep 6, 2023
Comment on lines
+34
to
+39
| . Added constant DOMNode::DOCUMENT_POSITION_DISCONNECTED. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_PRECEDING. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_FOLLOWING. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_CONTAINS. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_CONTAINED_BY. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC. |
Member
There was a problem hiding this comment.
Would it make sense to make this an enum?
Member
Author
There was a problem hiding this comment.
I thought about that too. The problem is that they're bitflags, so they might be OR'ed with eachother. That's something not supported with enums right now.
Member
There was a problem hiding this comment.
Enum sets would be nice to have indeed :(
Girgias
approved these changes
Sep 8, 2023
Comment on lines
+34
to
+39
| . Added constant DOMNode::DOCUMENT_POSITION_DISCONNECTED. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_PRECEDING. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_FOLLOWING. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_CONTAINS. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_CONTAINED_BY. | ||
| . Added constant DOMNode::DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC. |
Member
There was a problem hiding this comment.
Enum sets would be nice to have indeed :(
|
|
||
| /* Special case: comparing children and attributes. | ||
| * They belong to a different tree and are therefore hard to compare, but spec demands attributes to precede children | ||
| * according to the pre-order DFS numbering. |
Member
Author
There was a problem hiding this comment.
Depth-first search. I'll write it out in full.
Comment on lines
+23
to
+35
| --EXPECT-- | ||
| --- Compare 0 and 1 --- | ||
| int(36) | ||
| --- Compare 0 and 2 --- | ||
| int(36) | ||
| --- Compare 1 and 2 --- | ||
| int(36) | ||
| --- Compare 1 and 0 --- | ||
| int(34) | ||
| --- Compare 2 and 0 --- | ||
| int(34) | ||
| --- Compare 2 and 1 --- | ||
| int(34) |
Member
Author
There was a problem hiding this comment.
I'll clean it up so it's easier to understand.
Comment on lines
+36
to
+38
| echo "--- strong & bar ---\n"; | ||
| var_dump($bar->nextElementSibling->compareDocumentPosition($bar) === DOMNode::DOCUMENT_POSITION_PRECEDING); | ||
| var_dump($bar->compareDocumentPosition($bar->nextElementSibling) === DOMNode::DOCUMENT_POSITION_FOLLOWING); |
Member
There was a problem hiding this comment.
How would the two strong tags compare?
Member
Author
There was a problem hiding this comment.
I'll add a test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://dom.spec.whatwg.org/#dom-node-comparedocumentposition