Unify type juggling in math.c#12286
Merged
Merged
Conversation
- Consistently use a `switch()` with `EMPTY_SWITCH_DEFAULT_CASE();` - Consistently use `zval_get_double()` for multi-type / non-double zvals instead of casting manually.
Girgias
approved these changes
Sep 23, 2023
| ZEND_ASSERT(0 && "Unexpected type"); | ||
| switch (Z_TYPE_P(value)) { | ||
| case IS_LONG: | ||
| if (Z_LVAL_P(value) == ZEND_LONG_MIN) { |
Member
There was a problem hiding this comment.
Possibly as a follow-up wrapping this unlikely condition in UNEXPECTED() might make sense.
Member
Author
There was a problem hiding this comment.
This case is a little odd anyway. For 32 bit versions it made sense, because doubles would be able to accurately represent 2147483648, but for 64 bit versions they are not capable of accurately representing 9223372036854775808. I wonder if this should throw instead.
Member
Author
There was a problem hiding this comment.
Now wrapped in UNEXPECTED, this actually results in slightly better assembly.
TimWolla
added a commit
that referenced
this pull request
Sep 24, 2023
As suggested in GH-12286. This results in slightly better assembly in clang, because the expected case will be handled by a forward jump that is not taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As privately suggested by @Girgias.