Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Change default method of disabling JIT #12678

Closed
wants to merge 6 commits into from
Closed

[RFC] Change default method of disabling JIT #12678

wants to merge 6 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Nov 15, 2023 •
edited

@danog
Copy link
Contributor Author

danog commented Nov 15, 2023

Btw @iluuu1994 question, I may have messed up the order listed in https://wiki.php.net/rfc/howto a bit, I basically wrote the entire RFC in the email I sent to internals around a month ago, without actually creating the RFC itself on on https://wiki.php.net/, do you think that can count as a discussion period, can I send the one-day pre-voting heads up email already or should I wait some more 2 weeks?

@iluuu1994
Copy link
Member

@danog If you want to avoid unnecessary drama it's probably better to wait. I suppose it's possible that some people don't take a close look at RFC ideas until there's a formal draft. Two weeks is not long, given how early we are in the development process of 8.4.

@danog danog changed the title [RFC] Change default method of disabling jit [RFC] Change default method of disabling JIT Nov 15, 2023
@TimWolla TimWolla added the RFC label Nov 15, 2023
@danog danog force-pushed the change_default_method_of_disabling_jit branch 2 times, most recently from b0914d8 to 7712504 Compare November 28, 2023 19:15
derickr
derickr reviewed Dec 3, 2023
View reviewed changes
UPGRADING Show resolved Hide resolved
@danog
Copy link
Contributor Author

danog commented Dec 23, 2023

Hi, the RFC was accepted, can we merge this? :)

@iluuu1994 iluuu1994 self-assigned this Dec 23, 2023
@iluuu1994
Copy link
Member

@danog I can take care of this soon. 🙂

iluuu1994
iluuu1994 reviewed Dec 23, 2023
View reviewed changes
UPGRADING Outdated Show resolved Hide resolved
ext/opcache/ZendAccelerator.c Outdated Show resolved Hide resolved
ext/opcache/jit/zend_jit.h Outdated Show resolved Hide resolved
ext/phar/tests/024-opcache-win32.phpt Show resolved Hide resolved
@danog danog force-pushed the change_default_method_of_disabling_jit branch from 3dbc3be to bd5a732 Compare December 23, 2023 18:31
@danog
Copy link
Contributor Author

danog commented Dec 28, 2023

Fixed!

@iluuu1994 iluuu1994 closed this in c16ad91 Jan 15, 2024
@iluuu1994
Copy link
Member

Great, thanks @danog!

@danog
Copy link
Contributor Author

danog commented Jan 15, 2024

Awesome, thank you! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypost andypost andypost left review comments

@derickr derickr derickr left review comments

@iluuu1994 iluuu1994 iluuu1994 left review comments

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees

@iluuu1994 iluuu1994

Labels
Extension: opcache Extension: phar RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danog @iluuu1994 @andypost @derickr @dstogov @TimWolla