RFC: new attribute #[NotSerializable] #12788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSem
force-pushed
the
not_serializable
branch
from
ca94772
to
70177cb
Compare
Girgias
reviewed
Nov 27, 2023
MaxSem
force-pushed
the
not_serializable
branch
from
70177cb
to
11c1b72
Compare
MaxSem
force-pushed
the
not_serializable
branch
2 times, most recently
from
c8e20b0
to
e7f9365
Compare
TimWolla
reviewed
Dec 9, 2023
MaxSem
force-pushed
the
not_serializable
branch
from
e7f9365
to
de88b97
Compare
Girgias
reviewed
Dec 9, 2023
| <?php | ||
|
|
||
| #[NotSerializable] | ||
| class C {} |
There was a problem hiding this comment.
There will need to be tests about extending a NonSerializable class, which also needs to determine if this works or not if the child class implements __serialize()/__unserialize()
There was a problem hiding this comment.
Maybe it's better to make it final? Why would anyone extend this attribute class?
There was a problem hiding this comment.
The attribute class is final. This is about classes that have the attribute applied.
MaxSem
force-pushed
the
not_serializable
branch
from
de88b97
to
732b522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/not_serializable