Skip to content

Fix GH-12996: Incorrect SCRIPT_NAME with ProxyPassMatch when + in path #13072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-12996: Incorrect SCRIPT_NAME with ProxyPassMatch when + in path #13072

wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Jan 4, 2024

This fixes incorrect URL decoding with Apache ProxyPassMatch when percent and plus sign is in the path. The problem was that php_url_decode was used which replaces + with space. The fix is to use php_raw_url_decode which does not treat + specially.

@bukka bukka changed the base branch from master to PHP-8.2 January 4, 2024 14:54
@bukka bukka force-pushed the fpm_fcgi_envs_ap_pp_sn_strip_enc_plus branch from 6ee132d to 8c7499c Compare January 4, 2024 14:55
@bukka bukka mentioned this pull request Jan 4, 2024
Closed
Girgias
Girgias approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bukka bukka closed this in b04b09e Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bukka @Girgias