Create book for docs #13338
Closed
Create book for docs #13338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
php-src-docs
branch
2 times, most recently
from
8a58eda
to
b6e9335
Compare
bukka
reviewed
Feb 6, 2024
iluuu1994
force-pushed
the
php-src-docs
branch
3 times, most recently
from
530b93d
to
59050fe
Compare
iluuu1994
force-pushed
the
php-src-docs
branch
from
59050fe
to
08b9643
Compare
iluuu1994
force-pushed
the
php-src-docs
branch
from
08b9643
to
a173e0c
Compare
iluuu1994
force-pushed
the
php-src-docs
branch
from
d8ea490
to
7cd5b04
Compare
|
@iluuu1994 Awesome work! Thanks very much for coming up with this idea. First, I was very surprised that the content of the internals book is not reused, but then I saw the (hidden) thread, so now the reason is clear. However, I'm wondering If there is anything left which still blocks the merge of this PR? As far as I see, the docs could be improved incrementally later on. For one, I'd like to contribute my part to the docs in the near future, that's why I'm asking this. |
|
No blocker, I was waiting for feedback from the list. I also wanted to add some chapters first just to give an idea of the depth and language that is expected. I'll merge this PR soon. |
iluuu1994
force-pushed
the
php-src-docs
branch
from
f516936
to
72a0694
Compare
|
@kocsismate Merged, any help with the documentation is appreciated 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: https://iluuu1994.github.io/php-src/