Improved zend_string API #1367
Closed
Improved zend_string API #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing methods
Does not change anything to the generated code (thanks to compat macros) but cleaner.
flaupretre
force-pushed
the
zend_string_API
branch
from
a48be21 to
d96eab8
Compare
|
Comment on behalf of ab at php.net: Merged by Dmitry. Thanks for the contribution, Francois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements the zend_string API with some missing macros and functions. It also unifies the macro names to use the 'ZSTR_' prefix (compatibility macros for the previous names are provided).
The code using these macros has been modified to use the new 'ZSTR' names. That's cleaner but not mandatory. If you think that it represents too many changes, don't merge the second commit.
This PR contains only additions. It does not create any BC break.